[PATCH] D151012: [X86][NFC] Correct the instruction names for PUSH16i, PUSH32i

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 23:35:26 PDT 2023


maksfb accepted this revision.
maksfb added a comment.
This revision is now accepted and ready to land.

In D151012#4358288 <https://reviews.llvm.org/D151012#4358288>, @skan wrote:

> In D151012#4358279 <https://reviews.llvm.org/D151012#4358279>, @maksfb wrote:
>
>> Since it’s just internal names, it’s better to include NFC/NFCI in the title. clang-format is not happy. Otherwise, LGTM.
>
> You'd like me to clang-format the code in this patch too?

If it complains only about the existing code, it’s all good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151012/new/

https://reviews.llvm.org/D151012



More information about the llvm-commits mailing list