[llvm] f552247 - Revert "InstSimplify: Use isKnownNeverInfOrNaN"

Alina Sbirlea via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 22:33:06 PDT 2023


Author: Alina Sbirlea
Date: 2023-05-19T22:27:42-07:00
New Revision: f55224735ed39af16bccd7ff67b734fd758db6fc

URL: https://github.com/llvm/llvm-project/commit/f55224735ed39af16bccd7ff67b734fd758db6fc
DIFF: https://github.com/llvm/llvm-project/commit/f55224735ed39af16bccd7ff67b734fd758db6fc.diff

LOG: Revert "InstSimplify: Use isKnownNeverInfOrNaN"

This reverts commit 494dee0f7a7701a57f7c5b755b4133844d0dcbdf.
Related to the other reverts, causes test failure due to nan/inf
mismatch.

Added: 
    

Modified: 
    llvm/lib/Analysis/InstructionSimplify.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/InstructionSimplify.cpp b/llvm/lib/Analysis/InstructionSimplify.cpp
index e73b13f558ef..3a721eba832a 100644
--- a/llvm/lib/Analysis/InstructionSimplify.cpp
+++ b/llvm/lib/Analysis/InstructionSimplify.cpp
@@ -4091,10 +4091,14 @@ static Value *simplifyFCmpInst(unsigned Predicate, Value *LHS, Value *RHS,
       if (Pred == FCmpInst::FCMP_UNE && isKnownNeverInfinity(LHS, Q.DL, Q.TLI))
         return getTrue(RetTy);
       // LHS == Inf || LHS == NaN
-      if (Pred == FCmpInst::FCMP_UEQ && isKnownNeverInfOrNaN(LHS, Q.DL, Q.TLI))
+      if (Pred == FCmpInst::FCMP_UEQ &&
+          isKnownNeverInfinity(LHS, Q.DL, Q.TLI) &&
+          isKnownNeverNaN(LHS, Q.DL, Q.TLI))
         return getFalse(RetTy);
       // LHS != Inf && LHS != NaN
-      if (Pred == FCmpInst::FCMP_ONE && isKnownNeverInfOrNaN(LHS, Q.DL, Q.TLI))
+      if (Pred == FCmpInst::FCMP_ONE &&
+          isKnownNeverInfinity(LHS, Q.DL, Q.TLI) && // xxxx fixme
+          isKnownNeverNaN(LHS, Q.DL, Q.TLI))
         return getTrue(RetTy);
     }
     if (C->isNegative() && !C->isNegZero()) {


        


More information about the llvm-commits mailing list