[PATCH] D148010: [Pipelines] Don't run module optimization in full LTO pre-link

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D148010#4357657 <https://reviews.llvm.org/D148010#4357657>, @mehdi_amini wrote:

> Can you contrast this to the previous attempts like mine here: https://reviews.llvm.org/D29376 ?

As I commented on the other thread, the difference is that you replaced both the pre-link and the post-link pipelines, while this is only changing the pre-link pipeline. Fully aligning the post-link pipelines is a much more complex problem, in part because the full LTO post-link pipeline is compile-time sensitive, and in part because it is pretty much completely separate from all the other pipelines we have (which use minor variations of the general module simplification / module optimization framework). I think there are some things we can do to make the full LTO post-link pipeline closer to our other pipelines, but just replacing it with the thin LTO pipeline as you proposed is likely not going to be viable. (In particular, I believe it should be possible to mostly reuse the module optimization phase, but not the module simplification phase as-is.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148010/new/

https://reviews.llvm.org/D148010