[PATCH] D150997: [llvm] Split out DenseMapInfo<variant> specialization

Elliot Goodrich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 13:41:51 PDT 2023


IncludeGuardian added a comment.

I couldn't actually find a user of this specialization in llvm or clang. If the CI doesn't pick up any user then perhaps we would want to remove this specialization completely?

The implementation of `isEqual` is incorrect as it doesn't defer to other `isEqual` specializations, instead relying on `operator==`.  If this component is needed then I can follow up with a fix + tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150997/new/

https://reviews.llvm.org/D150997



More information about the llvm-commits mailing list