[llvm] 94063ca - [test] Make mut-rec-scc.ll a bit more robust

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 12:25:54 PDT 2023


Author: Arthur Eubanks
Date: 2023-05-19T12:25:44-07:00
New Revision: 94063cac47fb2d07e92d6922761e182f1e657764

URL: https://github.com/llvm/llvm-project/commit/94063cac47fb2d07e92d6922761e182f1e657764
DIFF: https://github.com/llvm/llvm-project/commit/94063cac47fb2d07e92d6922761e182f1e657764.diff

LOG: [test] Make mut-rec-scc.ll a bit more robust

By adding noinline

Also make the SCC have 3 functions to prevent test changes with an upcoming change.

Added: 
    

Modified: 
    llvm/test/Transforms/Inline/mut-rec-scc.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/Inline/mut-rec-scc.ll b/llvm/test/Transforms/Inline/mut-rec-scc.ll
index f7336a731f6e0..a846fd6b2a086 100644
--- a/llvm/test/Transforms/Inline/mut-rec-scc.ll
+++ b/llvm/test/Transforms/Inline/mut-rec-scc.ll
@@ -32,6 +32,28 @@ define void @test1() {
 
 define void @test2() {
 ; CHECK-LABEL: define void @test2(
+; CHECK-NEXT:    call void @test3()
+; CHECK-NEXT:    call void @test3()
+; CHECK-NEXT:    ret void
+;
+  call void @test3() noinline
+  call void @test3() noinline
+  call void @dummy()
+  call void @dummy()
+  call void @dummy()
+  call void @dummy()
+  call void @dummy()
+  call void @dummy()
+  call void @dummy()
+  call void @dummy()
+  call void @dummy()
+  call void @dummy()
+  call void @dummy()
+  ret void
+}
+
+define void @test3() {
+; CHECK-LABEL: define void @test3(
 ; CHECK-NEXT:    call void @test1()
 ; CHECK-NEXT:    call void @test1()
 ; CHECK-NEXT:    ret void
@@ -53,23 +75,22 @@ define void @test2() {
 }
 
 ; The inlined call sites should have the "function-inline-cost-multiplier" call site attribute.
-; This test is a bit fragile in the exact number of inlining that happens based on thresholds.
-define void @test3() {
-; CHECK-LABEL: define void @test3(
-; CHECK-NEXT:    call void @test2() #[[COSTMULT:[0-9]+]]
-; CHECK-NEXT:    call void @test2() #[[COSTMULT]]
-; CHECK-NEXT:    call void @test2() #[[COSTMULT]]
-; CHECK-NEXT:    call void @test2() #[[COSTMULT]]
-; CHECK-NEXT:    call void @test2() #[[COSTMULT]]
-; CHECK-NEXT:    call void @test2() #[[COSTMULT]]
-; CHECK-NEXT:    call void @test2() #[[COSTMULT]]
-; CHECK-NEXT:    call void @test2() #[[COSTMULT]]
+define void @f() {
+; CHECK-LABEL: define void @f(
+; CHECK-NEXT:    call void @test3() #[[COSTMULT:[0-9]+]]
+; CHECK-NEXT:    call void @test3() #[[COSTMULT]]
+; CHECK-NEXT:    call void @test3() #[[COSTMULT]]
+; CHECK-NEXT:    call void @test3() #[[COSTMULT]]
+; CHECK-NEXT:    call void @test3() #[[COSTMULT]]
+; CHECK-NEXT:    call void @test3() #[[COSTMULT]]
+; CHECK-NEXT:    call void @test3() #[[COSTMULT]]
+; CHECK-NEXT:    call void @test3() #[[COSTMULT]]
 ; CHECK-NEXT:    ret void
 ;
-  call void @test2()
-  call void @test2()
+  call void @test1()
+  call void @test1()
   ret void
 }
 
-; CHECK: [[COSTMULT]] = { "function-inline-cost-multiplier"="4" }
+; CHECK: [[COSTMULT]] = { noinline "function-inline-cost-multiplier"="4" }
 ; THREE: "function-inline-cost-multiplier"="9"


        


More information about the llvm-commits mailing list