[PATCH] D150900: [InstCombine] Insert a bitcast to enable merging similar store insts

Anshil Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 11:13:49 PDT 2023


gandhi21299 updated this revision to Diff 523869.
gandhi21299 marked an inline comment as done.
gandhi21299 added a comment.
Herald added subscribers: kerbowa, jvesely.

- Replaced bitwidth equivalence check with `isBitOrNoopPointerCastable()`
- Inserted `hasSameSpecialState()` check
- Added a test with different alignments
- Added ptrtoint test
- Created an AMDGPU-specific test for inttoptr. This test appears to add an iteration to instruction combining until it reaches a fixed point. That is, instcombine will assume that it will run indefinitely when instcombine-infinite-loop-threshold is set to 3 whereas the test passes when I change the threshold value to 4.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150900/new/

https://reviews.llvm.org/D150900

Files:
  llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
  llvm/test/Transforms/InstCombine/AMDGPU/merging-stores-into-successor.ll
  llvm/test/Transforms/InstCombine/merging-multiple-stores-into-successor.ll
  llvm/test/Transforms/InstCombine/store.ll
  llvm/test/Transforms/LoopVectorize/invariant-store-vectorization.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150900.523869.patch
Type: text/x-patch
Size: 14647 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230519/3d8f6285/attachment.bin>


More information about the llvm-commits mailing list