[PATCH] D150899: [PowerPC] Add DFP compare instructions.

[Amy Kwan via Phabricator via llvm-commits]

amyk added a comment.

I think this patch looks OK to me, but I had one question regarding it.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrDFP.td:40
+
+let isCompare = 1, mayRaiseFPException = 1 in {
+  def DCMPU : XForm_17<59, 642, (outs crrc:$BF), (ins f8rc:$RA, f8rc:$RB),
----------------
I noticed some other compare instructions set `hasSideEffects` to 0 accordingly, but I was wondering if we need to do that here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150899/new/

https://reviews.llvm.org/D150899