[PATCH] D150864: [AggressiveInstCombine] Handle the nested GEP/BitCast scenario in Load Merge.

Fri May 19 10:35:26 PDT 2023

efriedma added inline comments.

================
Comment at: llvm/test/Transforms/AggressiveInstCombine/AArch64/or-load.ll:2178
+  ; Don't move gep2_cast before gep2
+  %gep2_cast = bitcast i8* %gep2 to i32*
+  %ld2 = load i32, i32* %gep2_cast, align 4
----------------
bipmis wrote:
> efriedma wrote:
> > xbolva00 wrote:
> > > Typed pointers are gone, probably no new tests or fixes for them are allowed now.
> > > 
> > > @nikic ?
> > It isn't testing anything meaningful the way it's written, anyway; the pointer types are converted to "ptr" by the IR parser.
> As specified by @xbolva00 we should not be adding test cases for typed and opague pointers. If we still agree that this should be handled I can update the patch.
We don't need to add tests specifically for non-opaque pointers mode (-opaque-pointers=0), no.  So you can just get rid of this part of the test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150864/new/

https://reviews.llvm.org/D150864