[PATCH] D147783: [VPlan] Add stride->constant VPlan mapping at construction.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/RISCV/strided-accesses.ll:217
 define void @single_stride_int_scaled(ptr %p, i64 %stride) {
-; NOSTRIDED-LABEL: @single_stride_int_scaled(
-; NOSTRIDED-NEXT:  entry:
----------------
reames wrote:
> You're deleting - not updating - test lines here.  I think you may need to split an existing check clause so that a delta can be seen.  
Hm, not sure what went wrong there. Should be fixed now.


================
Comment at: llvm/test/Transforms/LoopVectorize/RISCV/strided-accesses.ll:734
 ; STRIDED-NEXT:    [[POINTER_PHI:%.*]] = phi ptr [ [[P]], [[VECTOR_PH]] ], [ [[PTR_IND:%.*]], [[VECTOR_BODY]] ]
-; STRIDED-NEXT:    [[POINTER_PHI11:%.*]] = phi ptr [ [[P2]], [[VECTOR_PH]] ], [ [[PTR_IND12:%.*]], [[VECTOR_BODY]] ]
-; STRIDED-NEXT:    [[INDEX:%.*]] = phi i64 [ 0, [[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], [[VECTOR_BODY]] ]
----------------
reames wrote:
> This deletion looks weird.  I don't know a reason that update_test_checks.py would produce this deletion.  
Hm, not sure what went wrong there. Should be fixed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147783/new/

https://reviews.llvm.org/D147783