[PATCH] D150107: [X86] Remove patterns for shift/rotate with immediate 1 and optimize during MC lowering

Fri May 19 07:56:27 PDT 2023

hans added a comment.

In D150107#4356347 <https://reviews.llvm.org/D150107#4356347>, @skan wrote:

> In D150107#4356140 <https://reviews.llvm.org/D150107#4356140>, @hans wrote:
>
>> In D150107#4356102 <https://reviews.llvm.org/D150107#4356102>, @hans wrote:
>>
>>>> skan mentioned this in rG2ef8ae134828 <https://reviews.llvm.org/rG2ef8ae134828876ab3ebda4a81bb2df7b095d030>: [X86] Remove patterns for ADC/SBB with immediate 8 and optimize during MC…
>>>
>>> That caused assert in Chromium builds. See https://bugs.chromium.org/p/chromium/issues/detail?id=1446973#c2 for a reproducer.
>>
>> I'll revert while that's investigated.
>
> @hans Thanks for the report! If you retested the reproducer before the revert, you would find it already passed after 5586bc539acb26cb94e461438de01a5080513401 <https://reviews.llvm.org/rG5586bc539acb26cb94e461438de01a5080513401>. So I reapplied the patch.
>
> It failed before b/c the last operand of `MCInst` ADC/SBBri could be an expression instead of an immediate.

Sorry about that. I didn't realize 5586bc539acb26cb94e461438de01a5080513401 <https://reviews.llvm.org/rG5586bc539acb26cb94e461438de01a5080513401> was a bug fix, and I obviously failed to re-run the test at head.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150107/new/

https://reviews.llvm.org/D150107