[PATCH] D150879: Add control of hex casing in APInt::toString

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 06:25:43 PDT 2023


thopre added a comment.

In D150879#4353625 <https://reviews.llvm.org/D150879#4353625>, @lattner wrote:

> I would suggest a silly microoptimization:
>
>   static const char BothDigits[] = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789abcdefghijklmnopqrstuvwxyz";
>   const char *Digits = BothDigits+(UpperCase ? 0 : 36);
>
> Avoids looking up two different GOT entries.

Changed and landed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150879/new/

https://reviews.llvm.org/D150879



More information about the llvm-commits mailing list