[PATCH] D150369: TypeFinder: collect target types

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 05:27:27 PDT 2023


nhaehnle added inline comments.


================
Comment at: llvm/include/llvm/IR/TypeFinder.h:72
+
+  StructType *&getStructType(unsigned Idx) { return StructTypes[Idx]; }
+
----------------
Flakebi wrote:
> As a getter, this should probably return `StructType *` instead of a reference?
It was a straight adjustment/rename of what used to be the operator[]; but it looks like that's unused? I'll double check and maybe just remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150369/new/

https://reviews.llvm.org/D150369



More information about the llvm-commits mailing list