[PATCH] D150868: [CodeGen] Rename `MachineInstr::defs` to `MachineInstr::explicit_defs` (NFC)

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 01:58:37 PDT 2023


barannikov88 added a comment.

In D150868#4355621 <https://reviews.llvm.org/D150868#4355621>, @foad wrote:

> This makes a lot of sense to me.
>
>> It is more difficult to find an appropriate name for `uses`
>
> Agreed. Maybe the solution is to remove `uses`? How "useful" is it? Can we migrate to `operands` and/or `implicit_operands`?

I tried, but it is not always obvious from the context what would be the correct change.
I got the impression that you are familiar with AMDGPU (it is one of the main consumers of defs()/uses(), as the diff shows),
so maybe you could handle this part?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150868/new/

https://reviews.llvm.org/D150868



More information about the llvm-commits mailing list