[PATCH] D149590: ValueTracking: Implement computeKnownFPClass for ldexp

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4222
+                                     Type *Ty) {
+  KnownFPClasses = Src.KnownFPClasses;
+  // If we aren't assuming the source can't be a zero, we don't have to check if
----------------
This is discarding anything we already knew. The docs should make that clear (for this function and propagateCanonicalizingSrc) - or change it so it only `&`s new information into KnownFPClasses.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149590/new/

https://reviews.llvm.org/D149590