[PATCH] D150220: [lld]: Fix RISC-V relaxation bug

Job Noorman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 00:55:50 PDT 2023


jobnoorman added a comment.

In D150220#4354466 <https://reviews.llvm.org/D150220#4354466>, @reames wrote:

> In D150220#4345935 <https://reviews.llvm.org/D150220#4345935>, @asb wrote:
>
>> It would likely be worth separating out the tests from this patch to ensure the bug isn't reintroduced in any future refactorings.
>
> Agreed.  @jobnoorman could I ask you to reduce a test here?  @kishore-rivos is an intern who has finished his internship.  I can take a shot at it, but I'm not really a linker person and I think you have a much better chance of getting a clean test on first attempt.

Sure! D150940 <https://reviews.llvm.org/D150940>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150220/new/

https://reviews.llvm.org/D150220



More information about the llvm-commits mailing list