[PATCH] D150838: [SimplifyCFG] add nuw/nsw on BuildLookuptable BitMap shiftwidth calculation

Kohei Asano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 22:03:13 PDT 2023


khei4 added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6139
+        /*HasNUW =*/true,
+        /*HasNSW =*/true);
 
----------------
nikic wrote:
> Does this comply with clang-format?
Actually seems subtle, inserted newlines look optional, but I will remove them.
as 
```
    ShiftAmt = Builder.CreateMul(
        ShiftAmt, ConstantInt::get(MapTy, BitMapElementTy->getBitWidth()),
        "switch.shiftamt", /*HasNUW =*/true, /*HasNSW =*/true);
```
Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150838/new/

https://reviews.llvm.org/D150838



More information about the llvm-commits mailing list