[PATCH] D150093: [KnownBits] Add implementation for `KnownBits::sdiv`

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n marked 2 inline comments as done.
goldstein.w.n added a comment.

In D150093#4353043 <https://reviews.llvm.org/D150093#4353043>, @foad wrote:

> In D150093#4353040 <https://reviews.llvm.org/D150093#4353040>, @goldstein.w.n wrote:
>
>> In D150093#4352283 <https://reviews.llvm.org/D150093#4352283>, @foad wrote:
>>
>>> Sorry I'm late.
>>
>> Shoot, this has already been pushed.
>>
>> Would you like me to create a follow up patch? (likewise for the udiv patch).
>
> Just FYI, on matters of process:
> https://llvm.org/docs/CodeReview.html#must-code-be-reviewed-prior-to-being-committed
> https://llvm.org/docs/CodeReview.html#can-code-be-reviewed-after-it-is-committed

Created D150921 <https://reviews.llvm.org/D150921>, D150922 <https://reviews.llvm.org/D150922>, and D150923 <https://reviews.llvm.org/D150923> think addressed all your concerns except the ones explicitly commented there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150093/new/

https://reviews.llvm.org/D150093