[PATCH] D149893: Rewrite LSV to handle longer chains.

[Justin Lebar via Phabricator via llvm-commits]

jlebar added a comment.

Thanks for the comments.



================
Comment at: llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:1012
+      return BasicBlock::reverse_iterator(ChainBegin);
+    else
+      return BasicBlock::iterator(ChainBegin);
----------------
arsenm wrote:
> No else after return throughout here
This one is necessary because it's an `if constexpr`.

I found two matches for `return.*\n.*else` that aren't constexpr and fixed those.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149893/new/

https://reviews.llvm.org/D149893