[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

Nice! Just some drive-by nitpicking, sorry 😅



================
Comment at: lld/test/wasm/async.ll:11
+
+define void @bar() #1 {
+    ret void
----------------



================
Comment at: lld/test/wasm/async.ll:21-22
+
+attributes #0 = { "wasm-async" }
+attributes #1 = { "wasm-async" }
+
----------------



================
Comment at: lld/test/wasm/merge-async-section.ll:26
+; Function index 1
+define void @bar() #1 {
+    ret void
----------------



================
Comment at: lld/test/wasm/merge-async-section.ll:38-39
+
+attributes #0 = { "wasm-async" }
+attributes #1 = { "wasm-async" }
+
----------------



================
Comment at: llvm/test/CodeGen/WebAssembly/async.ll:9
+
+define void @test1() #1 {
+  ret void
----------------



================
Comment at: llvm/test/CodeGen/WebAssembly/async.ll:13-14
+
+attributes #0 = { "wasm-async" }
+attributes #1 = { "wasm-async" }
+
----------------



================
Comment at: llvm/test/MC/WebAssembly/async.s:10-11
+
+.section        .custom_section.async,"",@
+    .int32  foo at FUNCINDEX
+
----------------
The intention looks little weird.. Is that what `llc` emits? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150803/new/

https://reviews.llvm.org/D150803