[PATCH] D150482: [AArch64] Don't use tbl lowering if ZExt can be folded into user.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 12:53:28 PDT 2023


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1818
       (!Arg0 || Arg0->getOpcode() != Extend->getOpcode() ||
        Arg0->getOperand(0)->getType() != Extend->getOperand(0)->getType()))
     return false;
----------------
efriedma wrote:
> Does this code do the right thing when the "Args" includes a cast with the wrong source type?  (In this case, the source type is i16, but the type of the operand of the cast would actually be i8.)
I don't think so, thanks! I updated the code to pass both source types in that case, not sure if there's a better way of handling that. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150482/new/

https://reviews.llvm.org/D150482



More information about the llvm-commits mailing list