[PATCH] D150697: [lld-macho] Remove linking bitcode support

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1659
+                  OPT_bitcode_symbol_map))
+    error("-bitcode_* arguments are no longer supported by Apple");
 
----------------
nit: wording seems slightly confusing here, since the bitcode args are still supported in ld64 (just not for App Store uploads). anyway see my suggestion in Options.td


================
Comment at: lld/MachO/Options.td:648-661
 
 def bitcode_bundle : Flag<["-"], "bitcode_bundle">,
     HelpText<"Generate an embedded bitcode bundle in the __LLVM,__bundle section of the output">,
+    Flags<[HelpHidden]>,
     Group<grp_bitcode>;
 def bitcode_hide_symbols : Flag<["-"], "bitcode_hide_symbols">,
     HelpText<"With -bitcode_bundle, hide all non-exported symbols from output bitcode bundle.">,
----------------
how about moving all these to `grp_obsolete`, with a message like "Obsolete since the App Store no longer supports the bitcode build flow"?

We could then drop the custom error message in Driver.cpp for these flags


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150697/new/

https://reviews.llvm.org/D150697