[PATCH] D149199: [SelectionDAG] Fill in some more cases in `isKnownNeverZero`

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 09:57:26 PDT 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5078
+    // The expression is really !Known.One[BitWidth-MaxLog2(Known):0].isZero()
+    if (computeKnownBits(Op.getOperand(0)).One[0], Depth + 1)
       return true;
----------------
RKSimon wrote:
> goldstein.w.n wrote:
> > RKSimon wrote:
> > > This looks like a bad merge?
> > hmm?
> Sorry, I think I was miscounting brackets :) 
You where right!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149199/new/

https://reviews.llvm.org/D149199



More information about the llvm-commits mailing list