[PATCH] D150870: [lld][Arm] Big Endian - Byte invariant support.
Amilendra Kodithuwakku via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 18 09:28:36 PDT 2023
amilendra added inline comments.
================
Comment at: lld/ELF/Arch/ARM.cpp:934
+DenseMap<InputSection *, std::vector<const Defined *>>
+elf::getArmMappingSymbolList() {
+ DenseMap<InputSection *, std::vector<const Defined *>> sectionMap;
----------------
amilendra wrote:
> `getArmMappingSymbolList` is called only within this file. So you can make it `static`.
Ah sorry. I did not see your comment that there is a chance that this can be used in `ARMErrataFix.cpp` as well. Ignore my comment of making it static.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150870/new/
https://reviews.llvm.org/D150870
More information about the llvm-commits
mailing list