[PATCH] D147108: [InstCombine] Add transforms for `(rem (shl Y, X), (shl Z, X))`

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 09:13:49 PDT 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp:1808
+    ShiftByX = true;
+  } else {
     return nullptr;
----------------
sdesmalen wrote:
> nit: unnecessary curly braces (same above)
IIRC, style is if any of the `if` need a curly, then all should have.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147108/new/

https://reviews.llvm.org/D147108



More information about the llvm-commits mailing list