[PATCH] D147544: [BOLT] Move from RuntimeDyld to JITLink

Thu May 18 08:59:23 PDT 2023

jobnoorman added a comment.

In D147544#4348350 <https://reviews.llvm.org/D147544#4348350>, @rafauler wrote:

> I have two issues on the X86 side that needs investigating: first, in most tests we look fine, but there is one binary that is mismatching eh_frame contents. Upon further inspection, I noticed that addresses of some functions in FDEs look off:
>
> F27479087: Screenshot 2023-05-16 at 4.07.20 PM.png <https://reviews.llvm.org/F27479087>
>
> To the left, we have reference BOLT, to the right, BOLT with this patch. This address 0x1c0c322d doesn't exist in the binary. This is HHVM binary (c++ with exceptions), built with GCC, being processed with "-lite=1 -reorder-functions=hfsort", but the issue might reproduce in any binary with lite=1 and eh_frame. It looks like addresses of functions that are not hot are getting corrupted, but it's just a guess.

Since HHVM is an open source project, I was wondering if it's possible to share a binary? I'm having trouble getting HHVM compiled myself and the binaries I find online don't have the necessary symbols/relocations. I'm also not able to reproduce this with simple binaries containing an `.eh_frame`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147544/new/

https://reviews.llvm.org/D147544