[PATCH] D149741: [InlineCost][TargetTransformInfo][AMDGPU] Consider cost of alloca instructions in the caller (2/2)

[Siu Chi Chan via Phabricator via llvm-commits]

scchan added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:1267
+      (ArgAllocaCost * getInliningThresholdMultiplier() * ArgAllocaSize) /
+      AllocaSize;
+
----------------
We should add your reasoning above to the comment.  I think changing this to `(ArgAllocaCost * getInliningThresholdMultiplier()) * (ArgAllocaSize/AllocaSize)` would make it more apparent that you are getting a fraction of that bonus.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149741/new/

https://reviews.llvm.org/D149741