[PATCH] D150868: [CodeGen] Rename `MachineInstr::defs` to `MachineInstr::explicit_defs`

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 created this revision.
Herald added subscribers: luke, mattd, gchakrabarti, pmatos, asb, asavonic, ormris, foad, frasercrmck, ecnelises, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, javed.absar, kbarton, hiraditya, jgravelle-google, arichardson, sbc100, jvesely, nemanjai, sdardis, dschuff, arsenm, MatzeB.
Herald added a project: All.
barannikov88 edited the summary of this revision.
barannikov88 edited the summary of this revision.
barannikov88 edited the summary of this revision.
barannikov88 edited the summary of this revision.
barannikov88 edited the summary of this revision.
barannikov88 added reviewers: craig.topper, arsenm, foad.
barannikov88 published this revision for review.
Herald added subscribers: llvm-commits, pcwang-thead, StephenFan, MaskRay, aheejin, wdng, jholewinski.
Herald added a project: LLVM.

`defs` and `uses` are two misnomers that have a very high potential of introducing bugs.
This patch deals with `defs` by giving it a proper name `explicit_defs`.
It is more difficult to find an appropriate name for `uses`, leave it as it is for now.
(`uses` returns explicit uses plus all implicit operands, including implicit defs.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150868

Files:
  llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h
  llvm/include/llvm/CodeGen/MachineInstr.h
  llvm/lib/CodeGen/CodeGenCommonISel.cpp
  llvm/lib/CodeGen/DetectDeadLanes.cpp
  llvm/lib/CodeGen/FixupStatepointCallerSaved.cpp
  llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
  llvm/lib/CodeGen/GlobalISel/Utils.cpp
  llvm/lib/CodeGen/MachineCopyPropagation.cpp
  llvm/lib/CodeGen/MachineLoopUtils.cpp
  llvm/lib/CodeGen/MachineScheduler.cpp
  llvm/lib/CodeGen/ModuloSchedule.cpp
  llvm/lib/CodeGen/SplitKit.cpp
  llvm/lib/CodeGen/TwoAddressInstructionPass.cpp
  llvm/lib/Target/AArch64/AArch64A57FPLoadBalancing.cpp
  llvm/lib/Target/AArch64/AArch64SpeculationHardening.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInsertDelayAlu.cpp
  llvm/lib/Target/AMDGPU/AMDGPUMachineCFGStructurizer.cpp
  llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
  llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp
  llvm/lib/Target/AMDGPU/SIPeepholeSDWA.cpp
  llvm/lib/Target/AMDGPU/SIPostRABundler.cpp
  llvm/lib/Target/AMDGPU/SIPreAllocateWWMRegs.cpp
  llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp
  llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
  llvm/lib/Target/Mips/MipsInstrInfo.cpp
  llvm/lib/Target/NVPTX/NVPTXProxyRegErasure.cpp
  llvm/lib/Target/PowerPC/PPCBranchCoalescing.cpp
  llvm/lib/Target/RISCV/RISCVRVVInitUndef.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyDebugFixup.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
  llvm/lib/Target/X86/X86CmovConversion.cpp
  llvm/lib/Target/X86/X86DomainReassignment.cpp
  llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150868.523355.patch
Type: text/x-patch
Size: 31886 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230518/32934756/attachment.bin>