[PATCH] D150855: MachineCombiner: consider all uses in getLatency()
Ramkumar Ramachandra via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 18 05:58:42 PDT 2023
artagnon added a comment.
In D150855#4352664 <https://reviews.llvm.org/D150855#4352664>, @barannikov88 wrote:
> In D150855#4352644 <https://reviews.llvm.org/D150855#4352644>, @artagnon wrote:
>
>> There are no test changes, but Embench shows a minor improvement in one test.
>
> Can this test be reduced and added to the review? I'm afraid this can't proceed without test coverage.
I just re-verified, and there are no benchmark changes either. I'm not sure how to cook up a test for this change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150855/new/
https://reviews.llvm.org/D150855
More information about the llvm-commits
mailing list