[PATCH] D139092: [LLD][ELF] Cortex-M Security Extensions (CMSE) Support

Thu May 18 05:57:35 PDT 2023

amilendra marked 6 inline comments as done.
amilendra added inline comments.

================
Comment at: lld/ELF/Arch/ARM.cpp:938
+    sym->size = eSym.st_size;
+
+    if (eSym.st_shndx != SHN_ABS) {
----------------
peter.smith wrote:
> What about the binding? IIUC it is possible to have a weak definition.
> 
> Do we need to record the type? Or are these implicitly STT_FUNC so it doesn't matter?
>From construction, only `weak` or `global` symbols will endup in the symbol table, and the linker errors for non `STT_FUNC` types so it should not matter, but I've added code to record `binding` and `type` just in case it will be useful later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139092/new/

https://reviews.llvm.org/D139092