[PATCH] D137201: [AggressiveInstCombine] Handle the insert point of the merged load correctly.

Biplob Mishra via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 05:06:56 PDT 2023


bipmis added a comment.

In D137201#4348346 <https://reviews.llvm.org/D137201#4348346>, @mnadeem wrote:

> Hi, this patch is creating malformed IR for some cases. Test case here:  https://github.com/llvm/llvm-project/issues/62756

Thanks for reporting. I can see the issue and have fixed it in https://reviews.llvm.org/D150864.
I have not optimised it exclusively in the AggressiveInstCombine Pass because the InstCombine does the same and generates a single GEP for the nested patterns which can be reduced. This is then Load merged by the AggressiveInstCombine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137201/new/

https://reviews.llvm.org/D137201



More information about the llvm-commits mailing list