[PATCH] D146918: [CMake] Don't set absolute paths as install runpaths on ELF platforms in llvm_setup_rpath()

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm added a comment.

@finagolfin

> If any LLVM subprojects are built separately, the LLVM build directory LLVM_LIBRARY_DIR is added to both the build and install runpaths in llvm_setup_rpath(), which is incorrect when installed.

Can I check if this statement is correct? It doesn't sound so to me.

I think this broke the nixpkgs build, which installs LLVM before doing an out of tree clang build which gets installed separately. The LLVM build directory is unavailable at clang build time. In this scenario, LLVM's LLVMConfig.cmake sets `LLVM_LIBRARY_DIR=the install path` during clang's `find_package(LLVM)` via the installed LLVMConfig.cmake;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146918/new/

https://reviews.llvm.org/D146918