[PATCH] D148787: [llvm-debuginfo-analyzer] Add combined selection for logical elements.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-debuginfo-analyzer.rst:468
 If the <pattern> criteria is too general, a more selective option can
 be specified to target a particular category of elements:
 lines (:option:`--select-lines`), scopes (:option:`--select-scopes`),
----------------
jmorse wrote:
> Good place to forward-reference the filtering/combined section?
Added a forward-reference to FILTER section.


================
Comment at: llvm/docs/CommandGuide/llvm-debuginfo-analyzer.rst:579
 
+COMBINED
+^^^^^^^^
----------------
jmorse wrote:
> Could I suggest that this section is titled and described in terms of "filter" rather than "combined selection" -- I think the meaning of "filter" is clear to all readers, and it'll be easier + quicker to understand the command line options if written in those terms.
> 
> As far as I understand it, all of the options you're adding are to reduce the number of things printed by filtering for a particular condition, right?
Section changed to `FILTER`.

Your understanding is correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148787/new/

https://reviews.llvm.org/D148787