[PATCH] D142313: [PowerPC] Replace PPCISD::VABSD cases with generic ISD::ABDU(X,Y) node

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 01:28:21 PDT 2023


lkail added a comment.

Hi @RKSimon

> The ABS(SUB(X,Y)) -> PPCISD::VABSD(X,Y,1) v4i32 combine wasn't legal (https://alive2.llvm.org/ce/z/jc2hLU) - so I've removed it, having already added the legal sub nsw tests equivalent.

For case where X and Y are both zero extended from other values, the original transformation looks still correct. See https://alive2.llvm.org/ce/z/LWaEEg.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142313/new/

https://reviews.llvm.org/D142313



More information about the llvm-commits mailing list