[PATCH] D118118: [SDAG] Preserve unpredictable metadata, teach X86CmovConversion to respect this metadata

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.
Herald added a subscriber: StephenFan.


================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:122
   MachineOperand *Operands = nullptr;   // Pointer to the first operand.
   unsigned NumOperands = 0;             // Number of operands on instruction.
 
----------------
RKSimon wrote:
> xbolva00 wrote:
> > xbolva00 wrote:
> > > Do we need *uint32* for NumOperands?
> > @RKSimon @craig.topper ?
> That might be possible - maybe investigate with a suitable check inside MachineInstr::addOperand?
Now done.


================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:124
 
-  uint16_t Flags = 0;                   // Various bits of additional
+  uint32_t Flags = 0;                   // Various bits of additional
                                         // information about machine
----------------
xbolva00 wrote:
> nikic wrote:
> > This will increase MI size by 8 bytes.
> Yes, but what we can do? 
> 
> Is it a big problem in practise? 
Last time I tried I was not able to observe ani significant memory usage regressions.
I reduced MI size by switching NumOperands to 16bits so I can get use these saved bits for Flags.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118118/new/

https://reviews.llvm.org/D118118