[PATCH] D123515: [RISCV] Support '.option arch' directive
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 17 23:16:56 PDT 2023
jrtc27 requested changes to this revision.
jrtc27 added a comment.
This revision now requires changes to proceed.
Issues need fixing before it lands, making exceptions sets a bad precedent
================
Comment at: llvm/test/MC/RISCV/option-arch.s:113
+
+# Test non quoted arch string
+.option arch, rv32ic
----------------
This seems like a holdover from back when this was allowing quoted strings, and doesn't distinguish it from the test earlier in the file
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123515/new/
https://reviews.llvm.org/D123515
More information about the llvm-commits
mailing list