[PATCH] D150505: [cmake] Disable GCC lifetime DSE

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 18:07:55 PDT 2023

jhuber6 added a comment.

In D150505#4351629 <https://reviews.llvm.org/D150505#4351629>, @thesamesam wrote:

> The counterpoint would be that _we're_ adding this flag (LLVM needs it) so it makes sense for us to swallow it, i.e. it's not an arbitrary user-defined flag.
> But I don't feel comfortable enough deciding what the right call is here and I'll defer to maskray & tstellar. Just let me know what I need to do, if anything.

This was my thought, this is a problem caused directly by LLVM including it against the user's will. I don't think we can simply say it's the build tool's or user's job to remove something they cannot control. Personally, I'm going to get very annoyed very fast deleting this flag from my `compiler_commands.json` when it gets regenerated every time I do a git pull or change a CMake file.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list