[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 17 14:50:56 PDT 2023
aeubanks added inline comments.
================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:476
+ FPM.addPass(EarlyCSEPass());
+
----------------
nikic wrote:
> Why the extra EarlyCSE pass in the `O1` pipeline?
forgot to update the commit message, see that
================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:547
+ SimplifyCFGPass(SimplifyCFGOptions().convertSwitchRangeToICmp(true)));
+ FPM.addPass(AggressiveInstCombinePass());
----------------
nikic wrote:
> Any particular reason why InstCombine and AggressiveInstCombine are no longer directly next to each other?
we need InstCombine -> SimplifyCFG, so swapped them (see updated commit message). I don't necessarily see why AIC needs to be right after IC
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145265/new/
https://reviews.llvm.org/D145265
More information about the llvm-commits
mailing list