[PATCH] D150545: [NFC][Py Reformat] Reformat python files in llvm

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 14:04:51 PDT 2023


barannikov88 added inline comments.


================
Comment at: llvm/utils/lit/lit/main.py:97
+            sys.stderr.write(
+                "Suppressing error because '--allow-empty-runs' " "was specified.\n"
+            )
----------------
thieta wrote:
> barannikov88 wrote:
> > It appears that the concatenated strings are not really concatenated. Note the `" "`.
> > 
> In Python you can concat strings without the + sign. In this case it's not necessary- but I doubt it will have any impact on the functionality 
Yeah, I know. This just strains a reader's brain. Might be worth doing a post-processing pass to eliminate these, but they are not easy to grep...



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150545/new/

https://reviews.llvm.org/D150545



More information about the llvm-commits mailing list