[PATCH] D150688: [cmake] Set CMP0091 to fix Windows builds after the cmake_minimum_required bump
Mike Hommey via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 17 13:25:41 PDT 2023
glandium added a comment.
Since you're mentioning `/MD`, I spotted this: https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/orc/CMakeLists.txt#L134, which ends up *not* adding `/MD` on the command line because of the quotes (ORC_CFLAGS containing -Isomething, this ends up adding an invalid directory that ends with `/MD` to the include list). This is yet another thing that should be done through setting the runtime properly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150688/new/
https://reviews.llvm.org/D150688
More information about the llvm-commits
mailing list