[PATCH] D150613: [SystemZ][z/OS] Implement yaml2obj for GOFF Object File Format

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added a comment.

There's a lot of code here. I'll try to look at it in the next couple of weeks. I was out last week and I'm a little behind.



================
Comment at: llvm/include/llvm/BinaryFormat/GOFF.h:33
+/// number of bytes we allow ourselves to attach to a card is thus arbitrarily
+/// limited to 32K-1 bytes.
+constexpr uint16_t MaxDataLength = 32 * 1024 - 1;
----------------
Has the spec been updated in the past three years? My z/OS 2.4 copy doesn't say that RLD records have an unsigned length field.

Also, if the spec is wrong about TXT cards then correcting the spec seems helpful. I don't know how difficult this is in practice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150613/new/

https://reviews.llvm.org/D150613