[PATCH] D150784: [NFC][Py Reformat] Reformat python files in the rest of the dirs
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 17 10:49:31 PDT 2023
MatzeB added a comment.
In D150784#4350299 <https://reviews.llvm.org/D150784#4350299>, @Mordante wrote:
> Thanks for working on this! LGTM!
>
> Note libc++ has more python files like `libcxx/utils/generate_header_inclusion_tests.py` are these intended to be reformatted too.
> If so I really prefer to postpone these files. I have some patches for them and I would prefer to avoid merge conflicts.
>
> Another question is it intended to validate the formatting? For libc++ we validate the formatting of our C++ code in the pre-commit CI. I really think it would be great to do that for these files too. If wanted I can do that too.
May be worth explaining here (or in the summary) as I don't think postponing for some changes makes sense. In fact I would expect this situation to be somewhat common, there is usually more silent unknown downstream users than you would expect.
The way to deal with this is to also run `black` on your changes and merging should be easy enough again. Something like copy your changes away, run black on copy, on merge conflict copy changes back to resolve...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150784/new/
https://reviews.llvm.org/D150784
More information about the llvm-commits
mailing list