[PATCH] D150544: [lld-macho] Remove partially supported 32-bit ARM arch

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 10:14:21 PDT 2023


barannikov88 added inline comments.


================
Comment at: lld/MachO/ConcatOutputSection.cpp:344-345
             /*isWeakDef=*/false, /*isExternal=*/false, /*isPrivateExtern=*/true,
-            /*includeInSymtab=*/true, /*isThumb=*/false,
+            /*includeInSymtab=*/true,
             /*isReferencedDynamically=*/false, /*noDeadStrip=*/false,
             /*isWeakDefCanBeHidden=*/false);
----------------
int3 wrote:
> could you run clang-format before landing? I think this can be reflowed
FWIW From my experience, clang-format does not join lines with argument comments.
A workaround is to join them manually (possibly exceeding column limit), then reformat.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150544/new/

https://reviews.llvm.org/D150544



More information about the llvm-commits mailing list