[PATCH] D150728: ValueTracking: Drop rounding mode check for constrained_sqrt in CannotBeNegativeZero

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:3809
+      // sqrt(-0.0) = -0.0, no other negative results are possible.
+      // FIXME: Account for denormal-fp-math=preserve-sign denormal inputs
     case Intrinsic::canonicalize:
----------------
Is this FIXME useful? How could denormal handling change this  behavior?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150728/new/

https://reviews.llvm.org/D150728