[PATCH] D150713: [llvm-debuginfo-analyzer] Support both Reference and Type attrs in single DIE

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 06:40:38 PDT 2023


CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/lib/DebugInfo/LogicalView/Readers/LVELFReader.cpp:1131
+                                            bool IsType) {
+  auto Iter = ElementTable.try_emplace(Offset).first;
+  // Update the element and all the references pointing to this element.
----------------
In the case of a new `offset` the original code created:

```
[Offset, LVElementEntry(nullptr, {Element}) ]
```
The new code:

```
[Offset, LVElementEntry(nullptr, References{}, Types{}) ]
```
The `Element` parameter is not recorded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150713/new/

https://reviews.llvm.org/D150713



More information about the llvm-commits mailing list