[PATCH] D150675: [AMDGPU] Rewrite device ctor / dtor handling to use .init / .fini sections

[Amit Kumar Pandey via Phabricator via llvm-commits]

ampandey-AMD added a comment.

In D150675#4346449 <https://reviews.llvm.org/D150675#4346449>, @jhuber6 wrote:

> I've tested this working with a standalone constructor, but it may be good to double check with the `asan` case.

I tested the above patch downstream with my asan-toolchain setup on r8 systems and found that the patch has no regressions with respect to both Hip/OpenMP runtimes of launching global ctor/dtors on amdgpu device code.

I have tested the above patches with asan test cases that stress test on the gpu side global-buffer-overflow conditions both with hip and openmp test cases and found the poisoning of redzones to be happening as we want.

I can share the test cases if any people has a working asan toolchain setup with the current patchset included.

Thanks
Amit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150675/new/

https://reviews.llvm.org/D150675