[PATCH] D149533: Regen some old tests; NFC

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/sub-cmp-peephole.ll:4
 ; RUN: llc < %s -mtriple=arm-apple-darwin | FileCheck %s --check-prefix=V7
 ; RUN: llc < %s -mtriple=armv8-none-linux-gnueabi | FileCheck %s -check-prefix=V8
 
----------------
RKSimon wrote:
> RKSimon wrote:
> > These need cleaning up - duplicate RUN, and I think you can have a common CHECK prefix as well
> > ```
> > ; RUN: llc < %s -mtriple=arm-apple-darwin | FileCheck %s --check-prefixes=CHECK,V7
> > ; RUN: llc < %s -mtriple=armv8-none-linux-gnueabi | FileCheck %s --check-prefixes=CHECK,V8
> > ```
> There's nothing darwin specific - so I think using this should be fine:
> ```
> ; RUN: llc < %s -mtriple=arm-none | FileCheck %s
> ; RUN: llc < %s -mtriple=armv7-none-linux-gnueabi | FileCheck %s --check-prefixes=V78,V7
> ; RUN: llc < %s -mtriple=armv8-none-linux-gnueabi | FileCheck %s -check-prefixes=V78,V8
> ```
> @dmgreen Any comments?
Yeah, that sounds OK to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149533/new/

https://reviews.llvm.org/D149533