[PATCH] D150664: MachineCombiner: use height in improvesCriticialPathLen()

[Ramkumar Ramachandra via Phabricator via llvm-commits]

artagnon abandoned this revision.
artagnon added a comment.

In D150664#4348803 <https://reviews.llvm.org/D150664#4348803>, @shiva0217 wrote:

> Theoretically, NewRootHeight and OldRootHeight should be equal.

You're absolutely right; I'll try to explain the improvements I'm seeing, and re-think this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150664/new/

https://reviews.llvm.org/D150664