[PATCH] D150753: [RISCV] Refactor parseVTypeI and use ParseFail if we parsed more than one identifier.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 03:27:44 PDT 2023


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

LGTM, but perhaps you could add a brief comment to parseVTypeToken explaining that VTypeState is used to track the parsing state machine, maybe indicated it should be set to VTypeState_SEW for the first call? It's not particularly hard to work out from the code, but I normally find just a little signposting useful when skimming.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150753/new/

https://reviews.llvm.org/D150753



More information about the llvm-commits mailing list