[PATCH] D150666: [WIP][GlobalISel] Combiner Intrinsic Matching

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp:462
+
+        // FIXME: This is needed, but prevents patterns such as
+        //   (match (G_FPTRUNC $fptrunc_dst, $fmed3_dst):$fptrunc,
----------------
Pierre-vh wrote:
> arsenm wrote:
> > Pierre-vh wrote:
> > > This is the most annoying bit at the moment. It's quite restrictive and the example in the github issue doesn't work because of it: https://github.com/llvm/llvm-project/issues/62628
> > Something is wrong with this "fully tested" code. It seems to just be wrong and mis-reports errors for cases which do match in the generated code (which is properly produced0
> Indeed, I think it's not entirely right. I will take a deeper look at it but I also hope @dsanders can help here :)
I just tried removing the error, but then I hit a crash in `applyForPartition` (`Assertion `Idx < Size && "Out-of-bounds Bit access."' failed.`)  so I'm guessing there's indeed something wrong with the match tree


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150666/new/

https://reviews.llvm.org/D150666