[PATCH] D147270: [DebugInfo] Support more than 2 operands in DWARF operations

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added a comment.

In D147270#4347572 <https://reviews.llvm.org/D147270#4347572>, @scott.linder wrote:

> I took a stab at a patch to address the assertion at D150713 <https://reviews.llvm.org/D150713>

Many thanks.

> Likely there is room to generalize it even further, but I can at least run the tool over e.g. `llc` in RelWithDebInfo mode, so I can do the same benchmark as for `llvm-dwarfdump`:
>
>   <stat>: <control> <patched> (<patched>/<control>)
>   instructions:u: 1896657656701 1896827456117 (1.000090)
>   Maximum resident set size: 51082468 51082618 (1.000003)
>   branches: 205322657743 205394850877 (1.000352)
>   branch-misses: 3028996914 2954952928 (0.975555)
>   User time: 451.593333 453.516667 (1.004259)
>
> It seems the two implementations are indistinguishable in this case (`llvm-debuginfo-analyzer --print=symbols build-relwithdebinfo/bin/llc` over three trials)
>
> Let me know what you think!

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147270/new/

https://reviews.llvm.org/D147270